> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Sent: Tuesday, June 7, 2022 9:49 AM
> To: Michael S. Tsirkin <mst@xxxxxxxxxx>; Eli Cohen <elic@xxxxxxxxxx>
> Cc: Jason Wang <jasowang@xxxxxxxxxx>; Si-Wei Liu <si-wei.liu@xxxxxxxxxx>; Parav Pandit <parav@xxxxxxxxxx>;
> virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/2] vdpa/mlx5: fix error code for deleting vlan
>
> Return success if we were able to delete a vlan. The current code
> always returns failure.
>
> Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> From review. (Not tested).
Acked-by: Eli Cohen <elic@xxxxxxxxxx>
>
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index b7a955479156..c964f4161d7f 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1814,6 +1814,7 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
>
> id = mlx5vdpa16_to_cpu(mvdev, vlan);
> mac_vlan_del(ndev, ndev->config.mac, id, true);
> + status = VIRTIO_NET_OK;
> break;
> default:
> break;
> --
> 2.35.1
