Le 06/06/2022 à 08:26, Wong Vee Khee a écrit :
On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote:
When the managed API is used, there is no need to explicitly call
pci_free_irq_vectors().
This looks to be a left-over from the commit in the Fixes tag. Only the
.remove() function had been updated.
So remove this unused function call and update goto label accordingly.
Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume")
Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
LGTM
Reviewed-by: Wong Vee Khee <vee.khee.wong@xxxxxxxxxxxxxxx>
Hi,
I've looked at it again.
I still think that the patch is good, but pcim_release() has changed in
5.18 since commit 3f35d2cf9fbc ("PCI/MSI: Decouple MSI[-X] disable from
pcim_release()")
I guess that all the mechanic is in place so that everything is
registered when needed, but I've not been able to figure it out in the
case of dwmac-intel.c.
So, double check :).
CJ
