The assoc_array_insert_mid_shortcut() function returns type bool. It's cleaner to "return true;" instead of returning the edit pointer cast to bool. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- lib/assoc_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/assoc_array.c b/lib/assoc_array.c index 079c72e26493..552a4970a9d1 100644 --- a/lib/assoc_array.c +++ b/lib/assoc_array.c @@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit, edit->leaf_p = &new_n0->slots[0]; pr_devel("<--%s() = ok [split shortcut]\n", __func__); - return edit; + return true; } /** -- 2.35.1