On Tue, May 24, 2022 at 03:07:18PM +0000, Yuri Nudelman wrote: > > Hi, > > In this flow gfp cannot be atomic, so there is no severe problem with > that. The fact I left explicit GFP_KERNEL flag in this code is a typo. > > This function serves as a callback, and is invoked via a function pointer > through the hl_mmap_mem_buf_alloc, which can receive a GFP_ATOMIC > argument, but not in the flow when the callback is hl_ts_alloc_buf. That's okay then. > > I will change it from GFP_KERNEL to gfp to avoid the warning, No don't do that. Just ignore false positives. Plus eventually we will implement the other check that I mentioned. regards, dan carpenter
