> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Christophe JAILLET > Sent: Saturday, May 21, 2022 12:27 PM > To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; > Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; > Paolo Abeni <pabeni@xxxxxxxxxx> > Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>; intel-wired- > lan@xxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx > Subject: [Intel-wired-lan] [PATCH] ice: Use correct order for the parameters > of devm_kcalloc() > > We should have 'n', then 'size', not the opposite. > This is harmless because the 2 values are just multiplied, but having the > correct order silence a (unpublished yet) smatch warning. > > While at it use '*tun_seg' instead '*seg'. The both variable have the same > type, so the result is the same, but it lokks more logical. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Tested-by: Gurucharan <gurucharanx.g@xxxxxxxxx> (A Contingent worker at Intel)
