On Tue, Apr 12, 2022 at 06:39:54PM +0300, Dan Carpenter wrote:
> If fwnode_property_count_u32() returns a negative error code then,
> because of type promotion, the "count > ARRAY_SIZE(pins)" condition
> will be true. The negative "count" is type promoted to a high unsigned
> size_t value.
>
> That means the "else if (count < 0)" condition will always be false and
> we don't print that error message or propagate the error code from
> fwnode_property_count_u32() as intended.
>
> Fix this by re-ordering the checks so that we check for negative first.
>
> Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Applied, thank you.
--
Dmitry
