On 06-04-22, 09:40, Dan Carpenter wrote:
> This code does not call of_node_put(opp_np) if of_get_next_available_child()
> returns NULL. But it should.
>
> Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> drivers/opp/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 440ab5a03df9..95b184fc3372 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)
>
> /* Checking only first OPP is sufficient */
> np = of_get_next_available_child(opp_np, NULL);
> + of_node_put(opp_np);
> if (!np) {
> dev_err(dev, "OPP table empty\n");
> return -EINVAL;
> }
> - of_node_put(opp_np);
>
> prop = of_find_property(np, "opp-peak-kBps", NULL);
> of_node_put(np);
Applied. Thanks.
--
viresh
