cpu_cache_sysfs_exit() already clears '&all_cpu_cache_info[cpu].kobj'. So there is no need to do it twice. Remove the redundant memset() and slightly simplify code. Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> --- This patch is provided as-is and is not even compile tested. I don't have the cross-building toolchain for that. --- arch/ia64/kernel/topology.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/ia64/kernel/topology.c b/arch/ia64/kernel/topology.c index 6adb84f05cbb..df58df614873 100644 --- a/arch/ia64/kernel/topology.c +++ b/arch/ia64/kernel/topology.c @@ -387,12 +387,8 @@ static int cache_remove_dev(unsigned int cpu) for (i = 0; i < all_cpu_cache_info[cpu].num_cache_leaves; i++) kobject_put(&(LEAF_KOBJECT_PTR(cpu,i)->kobj)); - if (all_cpu_cache_info[cpu].kobj.parent) { + if (all_cpu_cache_info[cpu].kobj.parent) kobject_put(&all_cpu_cache_info[cpu].kobj); - memset(&all_cpu_cache_info[cpu].kobj, - 0, - sizeof(struct kobject)); - } cpu_cache_sysfs_exit(cpu); -- 2.32.0