Re: [PATCH net-next] vxlan_core: delete unnecessary condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/7/22 05:07, Nikolay Aleksandrov wrote:
On 07/03/2022 15:05, Nikolay Aleksandrov wrote:
On 07/03/2022 14:57, Dan Carpenter wrote:
The previous check handled the "if (!nh)" condition so we know "nh"
is non-NULL here.  Delete the check and pull the code in one tab.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
This not a bug so a Fixes tag is innappropriate, however for reviewers
this was introduced in commit 4095e0e1328a ("drivers: vxlan: vnifilter:
per vni stats")
No, it was not introduced by that commit.
It was introduced by commit:
  1274e1cc4226 ("vxlan: ecmp support for mac fdb entries")

Forgot to add: patch looks good to me. :)
Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>

+1


Reviewed-by: Roopa Prabhu <roopa@xxxxxxxxxx>

LGTM too, thanks Dan





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux