Re: [PATCH] nvmem: check for allocation failure

[Rafał Miłecki <rafal@xxxxxxxxxx>]

On 2022-03-01 09:11, Dan Carpenter wrote:
> Check for if the kcalloc() fails.
>
> Fixes: 299dc152721f ("nvmem: brcm_nvram: parse NVRAM content into NVMEM 
> cells")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thank you!

Acked-by: Rafał Miłecki <rafal@xxxxxxxxxx>

> ---
>  drivers/nvmem/brcm_nvram.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
> index 439f00b9eef6..c80af8a31eba 100644
> --- a/drivers/nvmem/brcm_nvram.c
> +++ b/drivers/nvmem/brcm_nvram.c
> @@ -95,6 +95,8 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
>  	len = le32_to_cpu(header.len);
>
>  	data = kcalloc(1, len, GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;
>  	memcpy_fromio(data, priv->base, len);
>  	data[len - 1] = '\0';