On Mon, 21 Feb 2022 11:02:00 +0100 Michal Simek <monstr@xxxxxxxxx> wrote: > Hi, > > On 2/20/22 12:45, Jonathan Cameron wrote: > > On Sun, 13 Feb 2022 19:29:05 +0100 > > Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > > > >> Use devm_delayed_work_autocancel() instead of hand writing it. This is > >> less verbose and saves a few lines of code. > >> > >> devm_delayed_work_autocancel() uses devm_add_action() instead of > >> devm_add_action_or_reset(). This is fine, because if the underlying memory > >> allocation fails, no work has been scheduled yet. So there is nothing to > >> undo. > >> > >> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > > Looks good to me, but I'd ideally like some input from someone familiar with > > the driver. > > Anand told me that the change is fine that's why here is my > Acked-by: Michal Simek <michal.simek@xxxxxxxxxx> > > Jonathan: Anand decided to do change in his carrier that's why that emails won't > go through. But I am still around if you need something xilinx/amd to test. > > Thanks, > Michal Thanks Michal and best wishes to Anand for whatever comes next! Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a quick look before I expose this to linux-next. Thanks, Jonathan
