Re: [PATCH] hwmon: (asus-ec-sensors) fix a typo in asus_ec_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/5/22 01:59, Eugene Shalygin wrote:
On Sat, 5 Feb 2022 at 10:20, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

There is no such struct as "asus_ec_sensors", it was supposed to be
"ec_sensors_data".  This typo does not affect either build or runtime.

Thank you for the fix! Perhaps you could also replace the sizeof
argument below with *state to make the compiler check the declaration
type?


The weirdness is coming from the fact that the probe function is
really a shim and all work is done in configure_sensor_setup().
A more conventional implementation would not have that separate
function. Changing the above won't change that and on its own adds
little value. I applied the patch as-is.

Guenter



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux