On Mon, Jan 31, 2022 at 02:53:40AM +0000, Pkshih wrote: > On Sun, 2022-01-30 at 22:37 +0000, Colin Ian King wrote: > > When I check this patch, I find there is no 'break' for default case. > Do we need one? like > > @@ -226,6 +226,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index) > break; > default: > ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES]; > + break; No, it's not necessary. The choice of style is up to the original developer. regards, dan carpenter
