Re: [PATCH] wcn36xx: Uninitialized variable in wcn36xx_change_opchannel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Loic Poulain <loic.poulain@xxxxxxxxxx>
Subject: Re: [PATCH] wcn36xx: Uninitialized variable in wcn36xx_change_opchannel()
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Tue, 1 Feb 2022 21:34:28 +0000
Cc: wcn36xx@xxxxxxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20220201125941.GA22458@kili>
References: <20220201125941.GA22458@kili>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1

On 01/02/2022 12:59, Dan Carpenter wrote:

This code needs "channel" to be initialized to NULL for it to work
correctly.

Fixes: d6f2746691cb ("wcn36xx: Track the band and channel we are tuned to")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


good catch

Reviewed-by: Bryan O'Donoghue <bryan.odonghue@xxxxxxxxxx>

References:
- [PATCH] wcn36xx: Uninitialized variable in wcn36xx_change_opchannel()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] RDMA/mlx4: remove redundant assignment to variable nreq
Next by Date: Re: [PATCH][next] net/mlx5e: Fix spelling mistake "supoported" -> "supported"
Previous by thread: [PATCH] wcn36xx: Uninitialized variable in wcn36xx_change_opchannel()
Next by thread: Re: [PATCH] wcn36xx: Uninitialized variable in wcn36xx_change_opchannel()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux