On 1/30/2022 7:42 PM, Christophe JAILLET wrote: > In order to free resources correctly in the error handling path of > pt_core_init(), 2 goto's have to be switched. Otherwise, some resources > will leak and we will try to release things that have not been allocated > yet. > > Fixes: fa5d823b16a9 ("dmaengine: ptdma: Initial driver for the AMD PTDMA") > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Acked-by: Sanjay R Mehta <sanju.mehta@xxxxxxx> > --- > drivers/dma/ptdma/ptdma-dev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/ptdma/ptdma-dev.c b/drivers/dma/ptdma/ptdma-dev.c > index 8a6bf291a73f..3fa2a6ed4b68 100644 > --- a/drivers/dma/ptdma/ptdma-dev.c > +++ b/drivers/dma/ptdma/ptdma-dev.c > @@ -207,7 +207,7 @@ int pt_core_init(struct pt_device *pt) > if (!cmd_q->qbase) { > dev_err(dev, "unable to allocate command queue\n"); > ret = -ENOMEM; > - goto e_dma_alloc; > + goto e_pool; > } > > cmd_q->qidx = 0; > @@ -230,7 +230,7 @@ int pt_core_init(struct pt_device *pt) > /* Request an irq */ > ret = request_irq(pt->pt_irq, pt_core_irq_handler, 0, dev_name(pt->dev), pt); > if (ret) > - goto e_pool; > + goto e_dma_alloc; > > /* Update the device registers with queue information. */ > cmd_q->qcontrol &= ~CMD_Q_SIZE; >