> -----Original Message----- > From: Colin Ian King <colin.i.king@xxxxxxxxx> > Sent: 2022年1月24日 2:50 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; David S . Miller > <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; > netdev@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH] net: fec_ptp: remove redundant initialization of variable val > > Variable val is being initialized with a value that is never read, it is being > re-assigned later. The assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> Looks good for me, so Reviewed-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> Best Regards, Joakim Zhang > --- > drivers/net/ethernet/freescale/fec_ptp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/freescale/fec_ptp.c > b/drivers/net/ethernet/freescale/fec_ptp.c > index af99017a5453..7d49c28215f3 100644 > --- a/drivers/net/ethernet/freescale/fec_ptp.c > +++ b/drivers/net/ethernet/freescale/fec_ptp.c > @@ -101,7 +101,6 @@ static int fec_ptp_enable_pps(struct > fec_enet_private *fep, uint enable) > u32 val, tempval; > struct timespec64 ts; > u64 ns; > - val = 0; > > if (fep->pps_enable == enable) > return 0; > -- > 2.33.1
