Re: [PATCH] phy: cadence: Sierra: fix error handling bugs in probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15-01-22, 14:51, Dan Carpenter wrote:
> There are two bugs in the error handling:
> 1: If devm_of_phy_provider_register() fails then there was no cleanup.
> 2: The error handling called of_node_put(child) improperly leading to
>    a use after free.  We are only holding the reference inside the loop
>    so the last two gotos after the loop lead to a use after free bug.
>    Fix this by cleaning up the partial allocations (or partial iterations)
>    in the loop before doing the goto.

Applied, thanks

-- 
~Vinod



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux