> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of > Christophe JAILLET > Sent: Monday, January 10, 2022 12:12 AM > To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L > <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; > Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>; intel-wired- > lan@xxxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx > Subject: [Intel-wired-lan] [PATCH] igb: Remove useless DMA-32 fallback > configuration > > As stated in [1], dma_set_mask() with a 64-bit mask never fails if > dev->dma_mask is non-NULL. > So, if it fails, the 32 bits case will also fail for the same reason. > > So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to > be 1. > > Simplify code and remove some dead code accordingly. > > [1]: https://lkml.org/lkml/2021/6/7/398 > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > This patch was not part of the 1st serie I've sent. So there is no Reviewed-by > tag. > --- > drivers/net/ethernet/intel/igb/igb_main.c | 19 ++++++------------- > 1 file changed, 6 insertions(+), 13 deletions(-) > Tested-by: Gurucharan G <gurucharanx.g@xxxxxxxxx> (A Contingent worker at Intel)
