On Fri, Jan 07, 2022 at 10:26:33AM +0000, Filipe Manana wrote: > On Fri, Jan 07, 2022 at 10:24:30AM +0300, Dan Carpenter wrote: > > These error paths unlock before the goto, but the goto also unlocks > > so it's a double unlock. > > There's also the case where there's an unlock without a previous lock. > I've just sent out a different version of the patch that fixes that as well: > > https://lore.kernel.org/linux-btrfs/a7b1b2094bb0697dda72bdd9bf1ed789cb0b9b08.1641550850.git.fdmanana@xxxxxxxx/ Ah! Thanks. regards, dan carpenter