On Wed, Dec 29, 2021 at 12:15:53PM +0100, Lukas Bulwahn wrote:
> Commit c8dcf655ec81 ("x86/build: Tuck away built-in firmware under
> FW_LOADER") intends to add the expression regex only when FW_LOADER is
> built-in, not a module or disabled.
>
> The config is called CONFIG_FW_LOADER when it is built-in; and
> CONFIG_FW_LOADER_MODULE when it is a module.
>
> So, adjust the condition to the actual name of the config.
>
> Fixes: c8dcf655ec81 ("x86/build: Tuck away built-in firmware under FW_LOADER")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---
>
> I am wondering if this regular expression needs to be made differently
> depending on the build configuration at all.
>
> Could this not just be added unconditionally anyway or is not needed at all?
> It seems that is was broken since its initial inclusion and nobody ever noticed.
Very few people use built-in firmware, which is why no one probably ever
noticed this :(
Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
