Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Smatch complains that there is a double free in probe:
>
> drivers/net/wireless/microchip/wilc1000/spi.c:186 wilc_bus_probe() error: double free of 'spi_priv'
> drivers/net/wireless/microchip/wilc1000/sdio.c:163 wilc_sdio_probe() error: double free of 'sdio_priv'
>
> The problem is that wilc_netdev_cleanup() function frees "wilc->bus_data".
> That's confusing and a layering violation. Leave the frees in probe(),
> delete the free in wilc_netdev_cleanup(), and add some new frees to the
> remove() functions.
>
> Fixes: dc8b338f3bcd ("wilc1000: use goto labels on error path")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
Patch applied to wireless-drivers-next.git, thanks.
4894edacfa93 wilc1000: fix double free error in probe()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211217150311.GC16611@kili/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
