Hi Lukas,
Thanks for the patch!
On Mon, 2021-12-13 at 12:16 +0100, Lukas Bulwahn wrote:
> Commit 4042147a0cc6 ("MIPS: Add Realtek RTL838x/RTL839x support as generic
> MIPS system") introduces config MACH_REALTEK_RTL, which selects the
> non-existing config SYS_HAS_EARLY_PRINTK_8250.
>
> As the MACH_REALTEK_RTL config also selects SYS_HAS_EARLY_PRINTK and
> USE_GENERIC_EARLY_PRINTK_8250, an early printk with 8250 should be covered.
> Probably SYS_HAS_EARLY_PRINTK_8250 is just some left-over from an early
> draft version of this commit.
>
> Drop selecting the non-existing config SYS_HAS_EARLY_PRINTK_8250.
>
> Fixes: 4042147a0cc6 ("MIPS: Add Realtek RTL838x/RTL839x support as generic MIPS system")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 00951bfdbab0..c89ce68d9580 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -640,7 +640,6 @@ config MACH_REALTEK_RTL
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_VPE_LOADER
> select SYS_HAS_EARLY_PRINTK
> - select SYS_HAS_EARLY_PRINTK_8250
> select USE_GENERIC_EARLY_PRINTK_8250
> select BOOT_RAW
> select PINCTRL
MACH_REALTEK_RTL doesn't actually call setup_8250_early_printk_port(). That means
USE_GENERIC_EARLY_PRINTK_8250 is also not needed. Being MIPS_GENERIC, that additionaly
means SYS_HAS_EARLY_PRINTK doesn't need to be selected.
I only recently found the MIPS_GENERIC "early" console therefore doesn't actually work,
but we use the "ns16550a" earlycon console instead. So feel free to also drop the other
two other EARLY_PRINTK symbols, if you think this is in-scope for this patch. Otherwise I
can submit a separate patch later.
In any case:
Acked-by: Sander Vanheule <sander@xxxxxxxxxxxxx>
Best,
Sander
