On Tue, Dec 07, 2021 at 10:37:35PM +0000, Colin Ian King wrote: > The variable chunks is being shifted right and re-assinged the shifted > value which is then returned. Since chunks is not being read afterwards > the assignment is redundant and the >>= operator can be replaced with a > shift >> operator instead. > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > --- > arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c > index c9f0f3d63f75..eaf25a234ff5 100644 > --- a/arch/x86/kernel/cpu/resctrl/monitor.c > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c > @@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width) > u64 shift = 64 - width, chunks; > > chunks = (cur_msr << shift) - (prev_msr << shift); > - return chunks >>= shift; > + return chunks >> shift; > } > > static u64 __mon_event_count(u32 rmid, struct rmid_read *rr) Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> Thanks. -Fenghua
