Re: [PATCH 3/3] scsi: hisi_sas: Use non-atomic bitmap functions when possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, <jejb@xxxxxxxxxxxxx>, <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] scsi: hisi_sas: Use non-atomic bitmap functions when possible
From: John Garry <john.garry@xxxxxxxxxx>
Date: Mon, 6 Dec 2021 14:30:20 +0000
Cc: <linux-scsi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxxx>
In-reply-to: <8ee33e463523db080e6a2c06f332e47abb69359b.1637961191.git.christophe.jaillet@wanadoo.fr>
References: <4afa3f71e66c941c660627c7f5b0223b51968ebb.1637961191.git.christophe.jaillet@wanadoo.fr> <8ee33e463523db080e6a2c06f332e47abb69359b.1637961191.git.christophe.jaillet@wanadoo.fr>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1

On 26/11/2021 21:18, Christophe JAILLET wrote:

All uses of the 'hisi_hba->slot_index_tags' bitmap are protected with the
'hisi_hba->lock' spinlock.

So prefer the non-atomic '__[set|clear]_bit()' functions to save a few
cycles.

Signed-off-by: Christophe JAILLET<christophe.jaillet@xxxxxxxxxx>


Acked-by: John Garry <john.garry@xxxxxxxxxx>

References:
- [PATCH 1/3] scsi: hisi_sas: Use devm_bitmap_zalloc() when applicable
  - From: Christophe JAILLET
- [PATCH 3/3] scsi: hisi_sas: Use non-atomic bitmap functions when possible
  - From: Christophe JAILLET

Prev by Date: Re: [PATCH] serial: 8250_pci: remove redundant assignment to tmp after the mask operation
Next by Date: [git:media_stage/master] media: media si2168: Fix spelling mistake "previsously" -> "previously"
Previous by thread: [PATCH 3/3] scsi: hisi_sas: Use non-atomic bitmap functions when possible
Next by thread: Re: [PATCH 1/3] scsi: hisi_sas: Use devm_bitmap_zalloc() when applicable
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]