From: Guanjun <guanjun@xxxxxxxxxxxxxxxxx> This free action should be moved into caller 'vduse_ioctl' in concert with the allocation. No functional change. Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Signed-off-by: Guanjun <guanjun@xxxxxxxxxxxxxxxxx> --- drivers/vdpa/vdpa_user/vduse_dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index c9204c62f339..477a5a592002 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b/drivers/vdpa/vdpa_user/vduse_dev.c @@ -1355,7 +1355,6 @@ static int vduse_create_dev(struct vduse_dev_config *config, err_str: vduse_dev_destroy(dev); err: - kvfree(config_buf); return ret; } @@ -1406,6 +1405,8 @@ static long vduse_ioctl(struct file *file, unsigned int cmd, } config.name[VDUSE_NAME_MAX - 1] = '\0'; ret = vduse_create_dev(&config, buf, control->api_version); + if (ret) + kvfree(buf); break; } case VDUSE_DESTROY_DEV: { -- 2.27.0