On Fri, Nov 26, 2021 at 2:31 PM Colin Ian King <colin.i.king@xxxxxxxxxxxxxx> wrote: > > The variable ret is being initialized with a value that is never > read, it is being updated later on. The assignment is redundant and > can be removed. Clean up the incorrectly indented following > declaration of variable code and move to the same line as the > declaration of variable ret. > > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx> > --- > arch/riscv/kernel/perf_event.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > This file will be removed in favor of a platform driver that has more rich support for perf. https://lkml.org/lkml/2021/10/25/1427 > diff --git a/arch/riscv/kernel/perf_event.c b/arch/riscv/kernel/perf_event.c > index c835f0362d94..cf3e2ac9bbb2 100644 > --- a/arch/riscv/kernel/perf_event.c > +++ b/arch/riscv/kernel/perf_event.c > @@ -156,8 +156,7 @@ static int riscv_map_cache_decode(u64 config, unsigned int *type, > static int riscv_map_cache_event(u64 config) > { > unsigned int type, op, result; > - int err = -ENOENT; > - int code; > + int err, code; > > err = riscv_map_cache_decode(config, &type, &op, &result); > if (!riscv_pmu->cache_events || err) > -- > 2.33.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish
