Re: [PATCH] nitro_enclaves: Remove redundant 'flush_workqueue()' calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/11/2021 19:09, Christophe JAILLET wrote:

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
-       flush_workqueue(E);
         destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
  drivers/virt/nitro_enclaves/ne_pci_dev.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.c b/drivers/virt/nitro_enclaves/ne_pci_dev.c
index 40b49ec8e30b..6b81e8f3a5dc 100644
--- a/drivers/virt/nitro_enclaves/ne_pci_dev.c
+++ b/drivers/virt/nitro_enclaves/ne_pci_dev.c
@@ -376,7 +376,6 @@ static void ne_teardown_msix(struct pci_dev *pdev)
         free_irq(pci_irq_vector(pdev, NE_VEC_EVENT), ne_pci_dev);

         flush_work(&ne_pci_dev->notify_work);
-       flush_workqueue(ne_pci_dev->event_wq);
         destroy_workqueue(ne_pci_dev->event_wq);

         free_irq(pci_irq_vector(pdev, NE_VEC_REPLY), ne_pci_dev);
--
2.30.2


Thank you for the patch.

Reviewed-by: Andra Paraschiv <andraprs@xxxxxxxxxx>

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux