Re: [PATCH] rtc: rv3032: fix error handling in rv3032_clkout_set_rate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>
Subject: Re: [PATCH] rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 12 Oct 2021 13:07:26 +0300
Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <20211012082548.GB31086@kili>
References: <20211012082548.GB31086@kili>
User-agent: Mutt/1.9.4 (2018-02-28)

On Tue, Oct 12, 2021 at 11:25:48AM +0300, Dan Carpenter wrote:
> Do not call rv3032_exit_eerd() if the enter function fails but don't
> forget to call the exit on if the enter succeeds.
                          ^^^^^
Let me resend... :/

regards,
dan carpenter

References:
- [PATCH] rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] block/rnbd-clt-sysfs: fix a couple uninitialized variable bugs
Next by Date: [PATCH v2] rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
Previous by thread: [PATCH] rtc: rv3032: fix error handling in rv3032_clkout_set_rate()
Next by thread: [PATCH] block/rnbd-clt-sysfs: fix a couple uninitialized variable bugs
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux