Hi Dan, thank you for this patch! On Mon, Oct 4, 2021 at 12:53 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The MESON_AO_RPROC_SRAM_USABLE_BITS macro is used like this: > > if (priv->sram_pa & ~MESON_AO_RPROC_SRAM_USABLE_BITS) { > dev_err(dev, "SRAM address contains unusable bits\n"); > > The problem is that "->sram_pa" is type phys_addr_t which is potentially > 64 bits. That means the MESON_AO_RPROC_SRAM_USABLE_BITS macro needs to > be a 64 bit type as well to ensure that high 32 bits are cleared. > > Fixes: 6cb58ea897dd ("remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> even though it's already applied, here's my: Tested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Best regards, Martin