On Mon, Sep 27, 2021 at 10:16 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > The error code is stored in "dev_priv", not "dev". The "dev" pointer > isn't initialized yet. > Hi Dan, This is already addressed in: https://patchwork.kernel.org/project/dri-devel/patch/20210924094040.3631675-1-yangyingliang@xxxxxxxxxx/ -Patrik > Fixes: c2f17e60cbe1 ("drm/gma500: Embed struct drm_device in struct drm_psb_private") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/gpu/drm/gma500/psb_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c > index 3d036d2a3b29..7a10bb39ef0b 100644 > --- a/drivers/gpu/drm/gma500/psb_drv.c > +++ b/drivers/gpu/drm/gma500/psb_drv.c > @@ -454,7 +454,7 @@ static int psb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > > dev_priv = devm_drm_dev_alloc(&pdev->dev, &driver, struct drm_psb_private, dev); > if (IS_ERR(dev_priv)) > - return PTR_ERR(dev); > + return PTR_ERR(dev_priv); > dev = &dev_priv->dev; > > pci_set_drvdata(pdev, dev); > -- > 2.20.1 >
