On Sat, Sep 18, 2021 at 7:32 AM Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > > In [1], Christoph Hellwig has proposed to remove the wrappers in > include/linux/pci-dma-compat.h. > > Some reasons why this API should be removed have been given by Julia > Lawall in [2]. > > Finally, Arnd Bergmann reminded that the documentation was updated 11 years > ago to only describe the modern linux/dma-mapping.h interfaces and mark the > old bus-specific ones as no longer recommended, see commit 216bf58f4092 > ("Documentation: convert PCI-DMA-mapping.txt to use the generic DMA API"). > > A coccinelle script has been used to perform the needed transformation > Only relevant parts are given below. > > @@ > expression e1, e2, e3, e4; > @@ > - pci_map_sg(e1, e2, e3, e4) > + dma_map_sg(&e1->dev, e2, e3, e4) > > @@ > expression e1, e2, e3, e4; > @@ > - pci_unmap_sg(e1, e2, e3, e4) > + dma_unmap_sg(&e1->dev, e2, e3, e4) > > @@ > expression e1, e2; > @@ > - pci_set_dma_mask(e1, e2) > + dma_set_mask(&e1->dev, e2) > > [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@xxxxxxxxxxxxx/ > [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/ > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > v2: Change Subject to be more explicit > Keep only relevant part of the coccinelle script > Try to improve the commit message to give some reason of why this change is done Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>