On Wed, 15 Sep 2021 11:05:42 +0000 Kumar, M Chetan wrote: > > This doesn't free the first region in devlink->cd_regions[0] so it's a memory > > leak. > > > > Fixes: 13bb8429ca98 ("net: wwan: iosm: firmware flashing and coredump > > collection") > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > drivers/net/wwan/iosm/iosm_ipc_devlink.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: M Chetan Kumar <m.chetan.kumar@xxxxxxxxx> I'll toss this from patchwork because I'm going to post a revert of the entire patch. The abuse of devlink params for configuring flashing process is unacceptable.