Re: [PATCH] usb: gadget: r8a66597: fix a loop in set_feature()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> This loop is supposed to loop until if reads something other than
> CS_IDST or until it times out after 30,000 attempts.  But because of
> the || vs && bug, it will never time out and instead it will loop a
> minimum of 30,000 times.
>
> This bug is quite old but the code is only used in USB_DEVICE_TEST_MODE
> so it probably doesn't affect regular usage.
>
> Fixes: 96fe53ef5498 ("usb: gadget: r8a66597-udc: add support for TEST_MODE")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>

-- 
balbi



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux