2021-09-06 22:44 GMT+09:00, Colin King <colin.king@xxxxxxxxxxxxx>: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Currently there are two ndr_read_int64 calls where ret is being checked > for failure but ret is not being assigned a return value from the call. > Static analyis is reporting the checks on ret as dead code. Fix this. > > Addresses-Coverity: ("Logical dead code") > Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions") > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Applied it to my queue. I will send it to Steve after testing. Thanks for your patch!