On Mon, Aug 30, 2021 at 06:33:24PM +0200, Roger Knecht wrote: > This patch fixes a small typo in the CRC ITU-T polynom documentation. > > The code comment says that the polynom is x^16 + x^12 + x^15 + 1, but the > correct polynom is x^16 + x^12 + x^5 + 1. > > Quote from page 2 in the ITU-T V.41 specification: > "2 Encoding and checking process > > The service bits and information bits, taken in conjunction, correspond > to the coefficients of a message polynomial having terms from x^(n-1) > (n = total number of bits in a block or sequence) down to x^16. This > polynomial is divided, modulo 2, by the generating polynomial > x^16 + x^12 + x^5 + 1. [...]" > > Source: https://www.itu.int/rec/T-REC-V.41-198811-I/en) > > The hex polynom 0x1021 and CRC code implementation are correct. > > Changes for the resend: > - Extended patch description > - Added additional CCs > > Thanks, > Roger Hi Roger, Can you put the Changes and the "Thanks" part of the email after ... > > Signed-off-by: Roger Knecht <roger@xxxxxxxxxxxxxxxxx> > --- ^^^ ... this cut off line so that they are not included in the final git log. These patches are applied with `cat raw_email.txt | git am -s` if you want to test how it works yourself. regards, dan carpenter
