On Tue, 24 Aug 2021 21:45:38 +0200 Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote: > Le 23/08/2021 à 08:42, Alexandru Ardelean a écrit : > > On Sat, Aug 21, 2021 at 1:43 PM Christophe JAILLET > > <christophe.jaillet@xxxxxxxxxx> wrote: > >> > >> A successful 'regulator_enable()' call should be balanced by a > >> corresponding 'regulator_disable()' call in the error handling path of the > >> probe, as already done in the remove function. > >> > >> Update the error handling path accordingly. > > > > Good catch. > > For the fix: > > > > Reviewed-by: Alexandru Ardelean <ardeleanalex@xxxxxxxxx> Applied and marked for stable. Thanks, > > > > If you want, you can also send a conversion to > > devm_iio_device_register() for this driver. > > And also move the regulator_disable() on a devm_add_action_or_reset() callback. > > Maybe, that's already part of your plan. If so, apologies for the noise :) > > > > Hi, > > I hadn't planned another step but I can send a follow-up patch for that. > > CJ Note I'll have to sit on that one until this patch is upstream which will be a few weeks (perhaps a month) given timing. Jonathan
