On Thu, Aug 19, 2021 at 09:52:07PM +0100, Sudip Mukherjee wrote: > On Fri, Jul 30, 2021 at 11:07 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote: > > > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > > > The check for count appears to be incorrect since a non-zero count > > check occurs a couple of statements earlier. Currently the check is > > always false and the dev->port->irq != PARPORT_IRQ_NONE part of the > > check is never tested and the if statement is dead-code. Fix this > > by removing the check on count. > > > > Note that this code is pre-git history, so I can't find a sha for > > it. > > > > Addresses-Coverity: ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Acked-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> > > Greg, can you please take it through your tree.. > I think you might not have it in your queue as you were not in the > original recipient list, if so, I can send it after adding my Ack to > it. Now picked up, thanks. greg k-h