On Wed, 2021-08-25 at 10:24 +0300, Dan Carpenter wrote: > This code works, but it's cleaner to use semi-colons at the end of > a statement instead of a comma. There are still multiple dozens of this type of comma use in the kernel. Julia Lawall created a cocci script to convert the commas to semicolons that worked pretty well. https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c [] > @@ -1039,12 +1039,12 @@ static int mxser_get_serial_info(struct tty_struct *tty, > if (closing_wait != ASYNC_CLOSING_WAIT_NONE) > closing_wait = jiffies_to_msecs(closing_wait) / 10; > > > - ss->type = info->type, > - ss->line = tty->index, > - ss->port = info->ioaddr, > - ss->irq = info->board->irq, > - ss->flags = info->port.flags, > - ss->baud_base = MXSER_BAUD_BASE, > + ss->type = info->type; > + ss->line = tty->index; > + ss->port = info->ioaddr; > + ss->irq = info->board->irq; > + ss->flags = info->port.flags; > + ss->baud_base = MXSER_BAUD_BASE; > ss->close_delay = close_delay; > ss->closing_wait = closing_wait; > ss->custom_divisor = MXSER_CUSTOM_DIVISOR,
