On Thu, Aug 05, 2021 at 08:02:28AM -0700, Davidlohr Bueso wrote: > On 2021-08-05 07:02, Arnd Bergmann wrote: > > The revert would appear to change the alignment to 16 bits instead > > of 32 bits on m68k as well (not 8 bits as on cris), but I don't know if > > that > > can cause problems there. > > Yeah I tried this a while back and it broke m68k, so it was a no go: > > https://lore.kernel.org/lkml/CAMuHMdXeZvJ0X6Ah2CpLRoQJm+YhxAWBt-rUpxoyfOLTcHp+0g@xxxxxxxxxxxxxx/ I'm still thinking that any architecture that doesn't respect natural alignment is playing with fire. For giggles we should put a runtime alignment check in READ_ONCE() and see what goes *bang*.