Re: [PATCH][next[next]] scsi: qla2xxx: Remove redundant initialization of variable num_cnt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/4/21 8:13 AM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The variable num_cnt is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
  drivers/scsi/qla2xxx/qla_edif.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
index fde410989c03..2db954a7aaf1 100644
--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -875,7 +875,7 @@ static int
  qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
  {
  	int32_t			rval = 0;
-	int32_t			num_cnt = 1;
+	int32_t			num_cnt;
  	struct fc_bsg_reply	*bsg_reply = bsg_job->reply;
  	struct app_pinfo_req	app_req;
  	struct app_pinfo_reply	*app_reply;


Looks Good.

(I am curious if that extra "next" in patch subject was a typo or some workflow added that)

Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>

--
Himanshu Madhani                                Oracle Linux Engineering



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux