Re: [PATCH] can: flexcan: Fix an uninitialized variable issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 29 Jul 2021 15:28:55 +0300
Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, wg@xxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, kuba@xxxxxxxxxx, angelo@xxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
In-reply-to: <20210729115744.ta5lo42d4metzxtf@pengutronix.de>
References: <a55780a2f4c8f1895b6bcbac4d3f8312b2731079.1627557857.git.christophe.jaillet@wanadoo.fr> <20210729113101.n5aucrwu56lyqhg7@pengutronix.de> <20210729114442.GT1931@kadam> <20210729115744.ta5lo42d4metzxtf@pengutronix.de>
User-agent: Mutt/1.9.4 (2018-02-28)

On Thu, Jul 29, 2021 at 01:57:44PM +0200, Marc Kleine-Budde wrote:
> Maybe it's time to fix the mcf5441x's clk_enable() as Geert pointed out.

Ah.  Thanks!  I'll send a patch for that.  In the mean time your patch
which sets "ret = 0;" is the correct fix.

regards,
dan carpenter

References:
- [PATCH] can: flexcan: Fix an uninitialized variable issue
  - From: Christophe JAILLET
- Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
  - From: Marc Kleine-Budde
- Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
  - From: Dan Carpenter
- Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
  - From: Marc Kleine-Budde

Prev by Date: [PATCH] m68k: coldfire: return success for clk_enable(NULL)
Next by Date: Re: [PATCH] m68k: coldfire: return success for clk_enable(NULL)
Previous by thread: Re: [PATCH] can: flexcan: Fix an uninitialized variable issue
Next by thread: [PATCH] dmaengine: idxd: Fix a possible NULL pointer dereference
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]