On 7/28/21 2:30 PM, Joe Perches wrote: > On 2021-07-28 12:41, Randy Dunlap wrote: >> On 7/28/21 8:37 AM, Joe Perches wrote: >>> On Mon, 2021-07-26 at 17:21 -0700, Randy Dunlap wrote: >>>> Running scripts/checkkconfigsymbols.py reports several hundred (maybe thousand) >>>> Kconfig symbols that are used questionably. Lots of these are false positives >>>> but lots of the remainder could use some cleaning up. >>> [] >>>> False positive example: >>>> >>>> XCHOFFLD_MEM >>>> Referencing files: drivers/scsi/qla2xxx/qla_mbx.c >>>> Similar symbols: OF_PMEM, CXL_MEM, CXL_PMEM >>>> >>>> The Referencing source file does this: >>>> #define CONFIG_XCHOFFLD_MEM 0x3 >>>> >>>> which is legitimate, so no change is needed. >>> >>> Legitimate is perhaps dubious. >>> >>> It might be better if Kconfig has exclusive use of CONFIG_<foo> naming so >>> renaming all the other existing CONFIG_<foo> defines might be appropriate. >> >> I would prefer that as well -- maybe 15 years ago. >> But I think it's too invasive to make that change now. > > I do not think it's that invasive. > > It's something that doesn't have to be done immediately either. > > It's not too many macro defines and not too many uses of those defines. OK :) I'm not trying to prevent such a change. Getting the exclusive use of CONFIG_symbols being dedicated to Kconfig namespace is the bug hurdle (IMO). -- ~Randy
