On Tue, Jun 29, 2021 at 06:21:32PM +0100, Colin Ian King wrote: > On 29/06/2021 18:19, Daniel Bristot de Oliveira wrote: > > On 6/29/21 6:52 PM, Colin King wrote: > >> From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > >> > >> The less than zero comparison of the u64 variable 'noise' is always > >> false because the variable is unsigned. Since the time_sub macro > >> can potentially return an -ve vale, make the variable a s64 to > >> fix the issue. > > > > Ops! concurrent bug fixing. > > Well, shows static analysis is doing it's thing and I'm not being > vigilant enough by spotting that Dan found it earlier :-) Nah. I don't normally CC kernel-janitors on bug reports. I sometimes do on netdev stuff because Dave told me ten years ago that static analysis noise on the list was an annoying thing. And actually on that one I didn't CC anyone actually, Oops. regards, dan carpenter
