Re: [PATCH] RDMA/rxe: missing unlock on error in get_srq_wqe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Jun 25, 2021, at 4:03 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> 
> This error path needs to unlock before returning.
> 
> Fixes: ec0fa2445c18 ("RDMA/rxe: Fix over copying in get_srq_wqe")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Majd Dibbiny <majd@xxxxxxxxxx>
> ---
> I'm sort of surprised this one wasn't caught in testing...
> 
> drivers/infiniband/sw/rxe/rxe_resp.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
> index 72cdb170b67b..3743dc39b60c 100644
> --- a/drivers/infiniband/sw/rxe/rxe_resp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_resp.c
> @@ -314,6 +314,7 @@ static enum resp_states get_srq_wqe(struct rxe_qp *qp)
> 
>   /* don't trust user space data */
>   if (unlikely(wqe->dma.num_sge > srq->rq.max_sge)) {
> +        spin_unlock_bh(&srq->rq.consumer_lock);
>       pr_warn("%s: invalid num_sge in SRQ entry\n", __func__);
>       return RESPST_ERR_MALFORMED_WQE;
>   }
> -- 
> 2.30.2




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux