Hello Colin, Dan,
On 22.06.21 17:39, Colin Ian King wrote:
> On 22/06/2021 16:31, Fabio Estevam wrote:
>> On Sat, Jun 19, 2021 at 3:23 AM Heiko Schocher <hs@xxxxxxx> wrote:
>>>
>>> Hello Dan,
>>>
>>> On 18.06.21 15:42, Dan Carpenter wrote:
>>>> Smatch complains that zero length read/writes will lead to an
>>>> uninitalized return value. I don't know if that's possible, but
>>>> it's nicer to return a zero literal anyway so let's do that.
>>>>
>>>> Fixes: 88d125026753 ("mtd: devices: add support for microchip 48l640 EERAM")
>>>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>>> ---
>>>> People, when we add a new driver can we make sure the first commit uses
>>>> the new prefered subsystem prefix? For example,
>>>>
>>>> "mtd: mchp48l640: add support for microchip 48l640 EERAM"
>>>> ^^^^^^^^^^
>>>> Otherwise it's not clear to me what I should use as a patch prefix.
>>>
>>> Ok, sorry...
>>>
>>> Hmm... Colin already sent a fix for this, see:
>>>
>>> https://lists.infradead.org/pipermail/linux-mtd/2021-June/087140.html
>>
>> Yes, both patches work, but I think Dan's solution is a bit clearer, so:
>>
>> Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
>>
>> Thanks
>>
> Yep, I'm good with that.
+1
Reviewed-by: Heiko Schocher <hs@xxxxxxx>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@xxxxxxx
