Re: [PATCH][next] regulator: bd9576: Fix uninitializes variable may_have_irqs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2021-06-22 at 15:47 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The boolean variable may_have_irqs is not ininitialized and is
> only being set to true in the case where chip is
> ROHM_CHIP_TYPE_BD9576.
> Fix this by ininitialized may_have_irqs to false.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: e7bf1fa58c46 ("regulator: bd9576: Support error reporting")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/regulator/bd9576-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/bd9576-regulator.c
> b/drivers/regulator/bd9576-regulator.c
> index 8b54d88827be..e16c3727db7a 100644
> --- a/drivers/regulator/bd9576-regulator.c
> +++ b/drivers/regulator/bd9576-regulator.c
> @@ -897,7 +897,7 @@ static int bd957x_probe(struct platform_device
> *pdev)
>  {
>  	int i;
>  	unsigned int num_reg_data;
> -	bool vout_mode, ddr_sel, may_have_irqs;
> +	bool vout_mode, ddr_sel, may_have_irqs = false;
>  	struct regmap *regmap;
>  	struct bd957x_data *ic_data;
>  	struct regulator_config config = { 0 };

Thanks a lot!
Acked-by: Matti Vaittinen <
matti.vaittinen@xxxxxxxxxxxxxxxxx>

Best Regards
	Matti Vaittinen




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux