Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 09 Jun 2021 23:01:38 -0400
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Tomas Henzl <thenzl@xxxxxxxxxx>, Kashyap Desai <kashyap.desai@xxxxxxxxxxxx>, Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <YMCJKgykDYtyvY44@mwanda> (Dan Carpenter's message of "Wed, 9 Jun 2021 12:26:02 +0300")
Organization: Oracle Corporation
References: <YMCJKgykDYtyvY44@mwanda>

Dan,

> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops.  Let's delete the
> confusing and impossible NULL check.

Applied 1+2 to 5.14/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
  - From: Dan Carpenter

Prev by Date: Re: [PATCH][next] net: dsa: sja1105: Fix assigned yet unused return code rc
Next by Date: Re: [PATCH net-next] net: tcp: Updating MSS, when the sending window is smaller than MSS.
Previous by thread: [PATCH 2/2] scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
Next by thread: Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]

Powered by Linux