On Wed, Jun 09, 2021 at 12:52:12PM +0300, Dan Carpenter wrote: > The "hi" variable is a u64 but the qca8k_read() writes to the top 32 > bits of it. That will work on little endian systems but it's a bit > subtle. It's cleaner to make declare "hi" as a u32. We will still need > to cast it when we shift it later on in the function but that's fine. > > Fixes: 7c9896e37807 ("net: dsa: qca8k: check return value of read functions correctly") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>