> -----Original Message----- > From: Baokun Li <libaokun1@xxxxxxxxxx> > Sent: Tuesday, June 8, 2021 8:39 AM > To: linux-kernel@xxxxxxxxxxxxxxx; Vinod Koul <vkoul@xxxxxxxxxx>; Michal > Simek <michals@xxxxxxxxxx>; Radhey Shyam Pandey <radheys@xxxxxxxxxx>; > Shravya Kumbham <shravyak@xxxxxxxxxx>; Matthew Murrian > <matthew.murrian@xxxxxxxxxx>; Romain Perier > <romain.perier@xxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; > Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Allen Pais <allen.lkml@xxxxxxxxx> > Cc: weiyongjun1@xxxxxxxxxx; yuehaibing@xxxxxxxxxx; > yangjihong1@xxxxxxxxxx; yukuai3@xxxxxxxxxx; libaokun1@xxxxxxxxxx; > dmaengine@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; kernel- > janitors@xxxxxxxxxxxxxxx; Hulk Robot <hulkci@xxxxxxxxxx> > Subject: [PATCH -next] dmaengine: xilinx_dma: Use list_move_tail instead of > list_del/list_add_tail > > Using list_move_tail() instead of list_del() + list_add_tail(). > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx> Thanks! > --- > drivers/dma/xilinx/xilinx_dma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 75c0b8e904e5..77022ef05ac5 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1411,8 +1411,7 @@ static void xilinx_vdma_start_transfer(struct > xilinx_dma_chan *chan) > > chan->desc_submitcount++; > chan->desc_pendingcount--; > - list_del(&desc->node); > - list_add_tail(&desc->node, &chan->active_list); > + list_move_tail(&desc->node, &chan->active_list); > if (chan->desc_submitcount == chan->num_frms) > chan->desc_submitcount = 0; >
