On Tue, Jun 08, 2021 at 11:10:41AM +0800, Baokun Li wrote:
> Using list_move() instead of list_del() + list_add().
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/irdma/puda.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/irdma/puda.c b/drivers/infiniband/hw/irdma/puda.c
> index 18057139817d..c0be6e37d425 100644
> --- a/drivers/infiniband/hw/irdma/puda.c
> +++ b/drivers/infiniband/hw/irdma/puda.c
> @@ -1420,8 +1420,7 @@ irdma_ieq_handle_partial(struct irdma_puda_rsrc *ieq, struct irdma_pfpdu *pfpdu,
> error:
> while (!list_empty(&pbufl)) {
> buf = (struct irdma_puda_buf *)(pbufl.prev);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Not related to your patch but this would be nicer as:
buf = list_last_entry(&pbufl, struct irdma_puda_buf, list);
> - list_del(&buf->list);
> - list_add(&buf->list, rxlist);
> + list_move(&buf->list, rxlist);
regards,
dan carpenter
